Avoid exporting lib ndk internals #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduce the surface of API, which expanded quite a bit with updated unwindstack. https://developer.android.com/ndk/guides/middleware-vendors debug builds export additional symbols used in the tests This change requires removal of code which re-throws types defined in binaries other than libbugsnag-ndk, because if the type has been hidden, then the throw invocation will trigger an immediate termination (skipping the crash report), or if the type is custom (e.g. a subclass of std::runtime_error, etc), then no useful message was detected anyway, as the type information is likely not available. Useful reading on the topic: * https://gcc.gnu.org/wiki/Visibility (specifically "Problems with C++ exceptions") * https://developer.android.com/ndk/guides/common-problems#rttiexceptions_not_working_across_library_boundaries * https://developer.android.com/ndk/guides/cpp-support#ic * https://en.cppreference.com/w/cpp/language/definition (section on ODR) Technically this lib should not export std:: symbols but this at least preserves existing behavior until its re-evaluated. [full ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Only expose the minimum surface required to make the library work, via a linker version script. They should be:
Java_*for JNI functionsbugsnag_*for the native API__cxa*,__gxx*and friends for C++ exception handlingChangeset
Testing
Tested manually that exception handling still worked as expected, though this change should be covered by the existing tests and addition of a specific test for C++ exception handling.